30 - Handle API response with value objects

本篇将介绍撰写 Rails 的过程中整个重构的过程，比较偏向一个方向，以一个简单的例子为例，假设我们请求 API 获取 Active 的 User 列表：

以下的程序是一个很常见的方法，但这段程序码中，不只打 Api + parser + 过滤 active user，这样的方式并没有办法让程序码只负责一件事情。

  response = Request.call('some_url')
  parsed_response = JSON.parse(response)

  eligible_users = []

  parsed_response['people'].each do |person|
    if person['active'] == true
      eligible_users << {
        name: "#{person['firstName']} #{person['lastName']}",
        email: person['emailAddress']
      }
    end
  end

  eligible_users

The parser for the people

Parser 的责任在负责接收并提供方法来 return User

  response = Request.call('some_url')
  parser = PeopleParser.new(response)

  eligible_users = []

  parser.people.each do |person|
    if person['active'] == true
      eligible_users << {
        name: "#{person['firstName']} #{person['lastName']}",
        email: person['emailAddress']
      }
    end
  end

  eligible_users

Value object for a person

我们需要一个 pure ruby object 来处理 person

  class Person
    def initialize(attributes)
      @attributes = attributes
    end

    def active?
      @attributes['active']
    end

    def email
      @attributes['emailAddress']
    end

    def name
      "#{@attributes['firstName']} #{@attributes['lastName']}"
    end
  end

有了上述的 Person Object 我们的 Parser 可以再来进行修改

  class PeopleParser
    def initialize(raw_response)
      @raw_response = raw_response
    end

    def people
      @parsed_json['people'].map { |attributes| Person.new(attributes) }
    end

    private

    def parsed_json
      @parsed_json ||= JSON.parse(@raw_response)
    end
  end

  response = Request.call('some_url')
  parser = PeopleParser.new(response)

  eligible_users = []

  parser.people.each do |person|
    if person.active?
      eligible_users << {
        name: person.name,
        email: person.email
      }
    end
  end

  eligible_users

再来继续重构：

Let person behave like a hash

接下来我们要命名一个 to_h 来组成 name + email 的 hash

  class Person
    def initialize(attributes)
      @attributes = attributes
    end

    def to_h
      {
        name: name,
        email: email
      }
    end

    def active?
      @attributes['active']
    end

    def email
      @attributes['emailAddress']
    end

    def name
      "#{@attributes['firstName']} #{@attributes['lastName']}"
    end
  end

程序码也变得更直观跟可读性了

  response = Request.call('some_url')
  parser = PeopleParser.new(response)

  eligible_users = parser.people.select(&:active?).map(&:to_h)

参考资料

• Handle API response with value objects

My blog

• https://chestertang.tw/